Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of this library #19

Open
dandv opened this issue Jan 21, 2025 · 2 comments
Open

Status of this library #19

dandv opened this issue Jan 21, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dandv
Copy link

dandv commented Jan 21, 2025

I'm curious about the status of this library. At a first look, I see a rather glaring typo in the first paragraph of the README, then there's a section that discusses "dual stack / triple-stack integration" now that JSR allows an ESM module to be imported from Node as well. Also, it's called "colorful logger colorful logger" but doesn't have any examples of using colors? While Deno supports logging with colors natively.

@fuxingZhang
Copy link
Contributor

Thank you for your issue.

I haven't worked with Node.js since around 2020 (from 2020 to 2024, I focused on Go, and starting in 2025, I'll be working with Swift, Go, and Rust), so I'm not very familiar with this area.

ESM Module Import from Node.js

The part about allowing ESM modules to be imported from Node was completed by @UrielCh, and I still don't understand the underlying principles. You can check the related issue here:

#5

@UrielCh, could you please take a look and explain how to call this library from Node.js and the underlying principles?

Examples of Using Colors

This library internally uses "jsr:@std/[email protected]/colors," but indeed, there are no examples of using colors as you mentioned. I think this is a cool feature. For the color requirement, there are two options:

  1. You can propose a requirement along with an example of the API call, and either I or @UrielCh can handle the coding work.
  2. Given that the code for this library is quite small, you can easily add this feature yourself. If you're willing, I would be more than happy to merge it.

@fuxingZhang fuxingZhang added the enhancement New feature or request label Jan 22, 2025
@dandv
Copy link
Author

dandv commented Jan 27, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants