Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop RSpec/DescribedClassModuleWrapping warnings #1111

Open
denny opened this issue May 7, 2021 · 0 comments
Open

Fix rubocop RSpec/DescribedClassModuleWrapping warnings #1111

denny opened this issue May 7, 2021 · 0 comments
Labels
code quality Primarily about code quality metrics (rather than deeper refactoring) feature plugins Involves one or more of the non-core plugins good first issue This issue should be suitable for less experienced developers help offered I would be very happy to help less experienced developers tackle this issue (advice/pairing/etc) tests Tests and test infrastructure (CI, etc)

Comments

@denny
Copy link
Owner

denny commented May 7, 2021

I've decided to move this into the rubocop todo file, as something that should be removed from the code at some point.

I think it's a pretty simple fix, but there are about 30 spec files that need changing so it migth takea while to work through.

Basic instructions:

  1. Remove the exception from the todo file.
  2. Run rubocop.
  3. For each file this cop warns about:
    a. Remove the module wrapper from the spec file
    b. Fix any class references in that file that need explicit namespacing after 3a

If anybody wants to pick it up, that'd be great (and I'm happy to help, just get in touch if you want a bit more explanation or even to pair on it), otherwise it can sit in the backlog until I want something simple to sort out :)

@denny denny added good first issue This issue should be suitable for less experienced developers tests Tests and test infrastructure (CI, etc) code quality Primarily about code quality metrics (rather than deeper refactoring) help offered I would be very happy to help less experienced developers tackle this issue (advice/pairing/etc) feature plugins Involves one or more of the non-core plugins labels May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Primarily about code quality metrics (rather than deeper refactoring) feature plugins Involves one or more of the non-core plugins good first issue This issue should be suitable for less experienced developers help offered I would be very happy to help less experienced developers tackle this issue (advice/pairing/etc) tests Tests and test infrastructure (CI, etc)
Projects
None yet
Development

No branches or pull requests

1 participant