Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine assets and assets_large in the dfx.json #1702

Closed
bdemann opened this issue Mar 10, 2024 · 1 comment
Closed

Combine assets and assets_large in the dfx.json #1702

bdemann opened this issue Mar 10, 2024 · 1 comment

Comments

@bdemann
Copy link
Member

bdemann commented Mar 10, 2024

It would be great if the developers didn't have to worry about which assets need to go where. Is there a way we could combine these two fields so that developers don't need to care about it. We could just run all assets through the assets_large path, but it's much quicker to put as many as possible in the binary. Is there a way to deterministically breakup which assets get uploaded by which method? So when we are creating the binary we run a function to determine which files go where, grab all those that go in the binary include them there, then when we finish building and deploying the binary we can run the same function but this time focus on the files that need to be uploaded via the assets_large approach and do that to those.

@bdemann
Copy link
Member Author

bdemann commented Jan 7, 2025

Closed by #1866

@bdemann bdemann closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant