From 8001110625dd95c188c7425d0d95f93abe65f03c Mon Sep 17 00:00:00 2001 From: doadin Date: Mon, 29 May 2023 16:30:57 -0400 Subject: [PATCH] [Packaging] Fix NSIS Uninstaller Not Removing File\Folder CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Website.lnk" "$INSTDIR\homepage.url" gets made in the installer but the uninstaller was looking for Delete "$SMPROGRAMS\$StartMenuFolder\Deluge Website.lnk" therefore this file was being left behind and since the folder was not empty $StartMenuFolder\Deluge was being left behinde as well. Closes: https://github.com/deluge-torrent/deluge/pull/426 --- packaging/win/deluge-win-installer.nsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/win/deluge-win-installer.nsi b/packaging/win/deluge-win-installer.nsi index ba67b9d836..1f9c2e271f 100644 --- a/packaging/win/deluge-win-installer.nsi +++ b/packaging/win/deluge-win-installer.nsi @@ -203,8 +203,8 @@ Section Uninstall !insertmacro MUI_STARTMENU_GETFOLDER Application $StartMenuFolder SetShellVarContext all Delete "$SMPROGRAMS\$StartMenuFolder\Deluge.lnk" + Delete "$SMPROGRAMS\$StartMenuFolder\Website.lnk" Delete "$SMPROGRAMS\$StartMenuFolder\Uninstall Deluge.lnk" - Delete "$SMPROGRAMS\$StartMenuFolder\Deluge Website.lnk" RmDir "$SMPROGRAMS\$StartMenuFolder" DeleteRegKey /ifempty HKCR "Software\Deluge"