-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed scrollbars and reduced first responder juggling #2327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for taking care! ❤️ this fixes all the issues i discovered after #2315 got merged!
also the code looks excellent and understandable to me, and also makes sense to me. i suggest to merge this PR as it fixes blocking issues.
for the testing: how can i start this testing in iOS? maybe we can add some hints to the README
@@ -2,7 +2,7 @@ import UIKit | |||
import DcCore | |||
|
|||
public class DraftArea: UIView, InputItem { | |||
public var inputBarAccessoryView: InputBarAccessoryView? | |||
public weak var inputBarAccessoryView: InputBarAccessoryView? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! excellent!
That was not intended to be included in this PR, it is not fully done yet. There is some issues I still need to figure out. |
closes #2323