Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor side effects of "ScrollView jumping improvements" #2323

Closed
r10s opened this issue Oct 15, 2024 · 1 comment · Fixed by #2327
Closed

minor side effects of "ScrollView jumping improvements" #2323

r10s opened this issue Oct 15, 2024 · 1 comment · Fixed by #2327
Assignees

Comments

@r10s
Copy link
Member

r10s commented Oct 15, 2024

"ScrollView jumping improvements" PR introduced some side effects that need to be targeted:

  • the icon shown on swipe-to-reply is flipped
  • tapping the system clock does not scroll up as usual, but scrolls down EDIT: might be okay, may be considered even as a fix as we no scroll to the most recent information; the scroll-up in eg. whatsapp is also more random as it scrolls just somewhere to the middle (as more messages are loaded there immediated)
  • the scrollbar is gone
  • input field is missing after using camera if the keyboard was not expanded before

cc @Amzd

@Amzd
Copy link
Collaborator

Amzd commented Oct 19, 2024

Did not fix the new behavior of status bar scrolling to the most recent message yet as other messengers (like discord) also do this. If users really want this we can always look at this again later. We will need to add a scrollview at the same level as the tableview which can intercept the status bar tap. So we'll need to use a UIViewController instead of UITableViewController.

Other issues are fixed in PR

@r10s r10s added the blocker label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants