Add Secta adapter #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xroll
reviewed
Apr 16, 2024
Comment on lines
35
to
42
| if (currentTick < tickLow) { | ||
| amount0 = BigInt(Math.floor(Number(liquidity) * ((sqrtRatioB - sqrtRatioA) / (sqrtRatioA * sqrtRatioB)))); | ||
| } else if (currentTick >= tickHigh) { | ||
| amount1 = BigInt(Math.floor(Number(liquidity) * (sqrtRatioB - sqrtRatioA))); | ||
| } else if (currentTick >= tickLow && currentTick < tickHigh) { | ||
| amount0 = BigInt(Math.floor(Number(liquidity) * ((sqrtRatioB - sqrtPrice) / (sqrtPrice * sqrtRatioB)))); | ||
| amount1 = BigInt(Math.floor(Number(liquidity) * (sqrtPrice - sqrtRatioA))); | ||
| } |
There was a problem hiding this comment.
hi, we are looking to remove inactive liquidity.
can you edit this part to not calculate any position that are out of range?
There was a problem hiding this comment.
I've removed first and second if statements.
|
Hi @lijac thanks for the PR. for linea points calculation, we are only considering LP positions that are active (in range). can you make changes to the codes ? you can also refer to sushi's PR : https://github.com/delta-hq/l2-lxp-liquidity-reward/pull/37/files |
|
@0xroll I'm late, thanks for review. I've updated code. How can I see if this is working in action? Is there a dashboard on your side? From performance perspective, I see sushi's code is much simpler than ours. Is it a big deal? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secta Finance
DEX uniswap-style v2 & v3