Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DODO - Issues #268

Open
0xroll opened this issue Jul 22, 2024 · 3 comments
Open

DODO - Issues #268

0xroll opened this issue Jul 22, 2024 · 3 comments

Comments

@0xroll
Copy link
Contributor

0xroll commented Jul 22, 2024

hi @xxamxx

the required functions are commented out, please make sure you have everything checked against the checklist

https://github.com/delta-hq/l2-lxp-liquidity-reward/blob/main/adapters/dodo/src/index.ts
@xxamxx
Copy link
Contributor

xxamxx commented Aug 1, 2024 •
edited
Loading

@0xroll ok, i found that I lack function readBlocksFromCSV and readBlocksFromCSV('hourly_blocks.csv') codes in adapters/dodo/src/index.ts.

but they had in adapters/runScript.js,is that okay?

@0xroll
Copy link
Contributor Author

0xroll commented Aug 2, 2024

@xxamxx they need to be in index.ts

@xxamxx xxamxx mentioned this issue Aug 2, 2024
Merged
17 tasks
0xroll added a commit that referenced this issue Aug 2, 2024
@0xroll
Merge pull request #276 from DODOEX/main
9f7eacc 
dodo: dex : fix issue #268
@xxamxx
Copy link
Contributor

xxamxx commented Aug 5, 2024

@0xroll please close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xxamxx @0xroll