DLPX-82895 default value for "fs.inotify.max_user_watches" is insufficient for the scale release testing setup

PR URL: https://www.github.com/delphix/delphix-platform/pull/426

Author: david-mendez1

.github/workflows/main.yml

@@ -2,46 +2,46 @@ on: [push, pull_request]
 
 jobs:
   check-packages:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - run: docker build -t delphix-platform:latest docker
       - run: ./scripts/docker-run.sh make packages
   check-shellcheck:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: delphix/actions/shellcheck@master
   check-shfmt:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: delphix/actions/shfmt@master
   check-pylint:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-python@v1
         with:
-          python-version: '3.6'
+          python-version: '3.8'
       - run: python3 -m pip install pylint
       - run: python3 -m pip install netifaces
       - run: pylint -d invalid-name,E0611 files/common/usr/bin/delphix-startup-screen
   check-yapf:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-python@v1
         with:
-          python-version: '3.6'
+          python-version: '3.8'
       - run: python3 -m pip install yapf
       - run: yapf --diff --style google files/common/usr/bin/delphix-startup-screen
   check-mypy:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-python@v1
         with:
-          python-version: '3.6'
+          python-version: '3.8'
       - run: python3 -m pip install mypy
       - run: mypy --ignore-missing-imports files/common/usr/bin/delphix-startup-screen

files/common/lib/sysctl.d/50-override.conf

@@ -92,4 +92,4 @@ fs.mount-max = 300000
 # We've seen cases where we run out of this resource with the default
 # value of 8192, resulting in upgrade failures.
 #
-fs.inotify.max_user_watches = 16384
+fs.inotify.max_user_watches = 32768

files/common/usr/bin/delphix-startup-screen

@@ -55,7 +55,7 @@ def get_svcs() -> List[str]:
     return cp.stdout.split("=", 1)[1].split()
 
 
-def run_svcs(options: str = None) -> Generator:
+def run_svcs(options: str = "") -> Generator:
     """
     Run the command to retrieve the status of all the services. The options
     argument can be used to obtain additional output from the 'systemctl'
@@ -245,7 +245,7 @@ def display_status(stdscr, win):
     status = 0
 
     x = int((X - width) / 2) + 2
-    y = (Y - height)
+    y = Y - height
 
     win.clear()
     win.box()