Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/node-local-dns]: Use selector labels for ServiceMonitor selectors #592

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[stable/node-local-dns]: Use selector labels for ServiceMonitor selectors #592

merged 1 commit into from
Jul 18, 2024

Conversation

AlonGluz
Copy link
Contributor

@AlonGluz AlonGluz commented Jul 18, 2024 •
edited
Loading

Description

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@AlonGluz AlonGluz requested a review from a team as a code owner July 18, 2024 12:18
max-rocket-internet
max-rocket-internet approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @AlonGluz 💛

@max-rocket-internet max-rocket-internet merged commit 3dfa109 into deliveryhero:master Jul 18, 2024
6 of 7 checks passed
fekaiser pushed a commit to gastromatic/delivery-hero-helm-charts that referenced this pull request Oct 23, 2024
@AlonGluz @fekaiser
[stable/node-local-dns]: Use selector labels for ServiceMonitor selec…
5dd1d7d 
…tors (deliveryhero#592)

use selecgtor labels for service monitor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlonGluz @max-rocket-internet