Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Make app_params more abstract #23

Open
Metallion opened this issue Sep 11, 2019 · 0 comments
Open

Make app_params more abstract #23

Metallion opened this issue Sep 11, 2019 · 0 comments

Comments

@Metallion
Copy link
Member

Metallion commented Sep 11, 2019

Currently there's code like this in Kaiserfiles.

app_params " -e CHROME_HOSTNAME=<%= @config[:shared_names][:chrome] %>"

That @config variable is code that gets eval'd in an instance of Kaiser::Cli and thus you need to know the internals of that class in order to write Kaiserfiles and refactoring it becomes hard without breaking existing Kaiserfiles.

When there is time, it would be a good idea to think of a way to make this more abstract.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant