Fix regex for ebs optimized setting #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidsiaw can you help us review this PR, please? |
davidsiaw
requested changes
Jul 24, 2023
| @@ -26,7 +26,7 @@ class AutoscalingBuilder < CloudFormation::Builder | |||
|
|
|||
| def ebs_optimized_by_default? | |||
| # https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSOptimized.html | |||
| !!(instance_type =~ /\A(a1|c4|c5.?|d2|f1|g3.?|h1|i3|m4|m5.?|m6()?|p2|p3(dn)?|r4|r5.?|t3|u-.*|x1.?|z1d)\..*\z/) | |||
| !!(instance_type =~ /\A(a1|c4|c5.?|d2|f1|g3.?|h1|i3|m4|m5.?|m6.+||p2|p3(dn)?|r4|r5.?|t3|u-.*|x1.?|z1d)\..*\z/) | |||
There was a problem hiding this comment.
might be an excess | character here
There was a problem hiding this comment.
Added some tests for this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #789
#789 has been deployed, but not applied to any districts yet. We will deploy this fix and then proceed with updating the districts.
It seems that all newer instance types support this, we just want to make sure this flag is enabled for m6 types in the Cloudformation when updating.
This should match any m6 instance type defined at https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-optimized.html#ebs-optimization-support