Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed duplicate logging to datadog for containers in ECS. Container logs are currently sent 2 ways.
Non-rsylog logs
Rsyslog logs
Historically, it seems we sent to rsyslog so that datadog and logentries would both be able to process the logs. We are no longer using logentries, and the datadog direct ingested logs have a lot more metadata than the rsyslog forwarded one.
In this PR we:
json-file
driver, and limit the size of each log file to 1MB.aws-logs
driver, as we will be charged to store them in Cloudwatch, and we don't plan to use them there.none
driver, as that stopped all logging, even from the datadog agent ingesting directly.Datadog configuration rollout
After this PR is merged, we do not need to update the datadog plugins districts to update the log functionality. The tasks will use the new configuration when they are deployed, as we are only changing how the plugins alter the task definition.
Logentries removal rollout
Logentries is already deactivated, but we still have the plugin installed on applications. This PR will remove the logentries configuration when an app is deployed. But we will still want to remove the plugin from all the districts using
bcn plugin delete
. Once it is removed from all districts, we can make a new PR to remove the code completely.Note:
Due to the rsyslog parsing, using the
service:
tag facet was different for each container. But the datadog direct ingest maps service to the short image name, which containers share. For queries that need to filter on the specific container, we recommend using thecontainer_name
facet now. Here is an example of what to use in the future.