Itamaecheck #725
Open
Itamaecheck #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@essa can you help us review this PR, please? |
essa
requested changes
Jun 2, 2022
There was a problem hiding this comment.
on_network_stack_template is for bastion, you need same update here for container instances.
def on_container_instance_user_data(_instance, user_data)
return user_data unless attributes['recipe_url'] =~ URI::regexp
install_itamae(user_data)
apply_itamae_recipe(user_data, attributes['recipe_url'], 'barcelona_container')
user_data
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail gracefully when the itamae plugin is installed but without a Recipe URL.
Without this, deploys start failing and all sorts of bad things happen.