throw error if heritage name already exits #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuuki77
force-pushed
the
validation-if-name-exits
branch
from
cf83872
to
2882ee6
Compare
|
@davidsiaw please review this |
|
Hmm. I think people should be allowed to create another heritage with the same heritage name in a different district. Is there a way to accommodate this? |
davidsiaw
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #617
Currently you can do
If you have district A and district B, it is possible to go
and then go
For now we need to prevent heritages of the same name created from being created.
Note
Originally, I tried to do this inside BuildHeritage class, but the BuildHeritage class is also used in the reviewApp, and is used in both the create and find. So, I decided to handle it in the controller.