From 928531095b7d9c154c268362e9a1470cf7c24ccf Mon Sep 17 00:00:00 2001 From: David Siaw Date: Mon, 22 Jan 2024 14:42:53 +0900 Subject: [PATCH] skip making non-ssl rules for reviewapps --- app/models/backend/ecs/v2/service_stack.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/models/backend/ecs/v2/service_stack.rb b/app/models/backend/ecs/v2/service_stack.rb index dd1f273e..204d70f8 100644 --- a/app/models/backend/ecs/v2/service_stack.rb +++ b/app/models/backend/ecs/v2/service_stack.rb @@ -4,7 +4,10 @@ class Builder < CloudFormation::Builder def build_resources deps = [] if use_alb? - deps = ['LBListenerRuleHTTP'] + deps = [] + if !service.heritage.review? + deps << 'LBListenerRuleHTTP' + end if listener&.endpoint&.https_listener_id&.present? deps << 'LBListenerRuleHTTPS'