Merge pull request #819 from degica/change_log_driver

Change log driver of runpack to json-file
degica · Sep 19, 2024 · 3d7224f · 3d7224f
2 parents d74a06d + 95617a5
commit 3d7224f
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 7 deletions.
diff --git a/app/models/heritage_task_definition.rb b/app/models/heritage_task_definition.rb
@@ -141,8 +141,16 @@ def run_pack_definition
       cpu: 1,
       memory: 16,
       essential: false,
-      image: "public.ecr.aws/degica/barcelona-run-pack"
+      image: "public.ecr.aws/degica/barcelona-run-pack",
+      log_configuration: {
+        log_driver: "json-file",
+        options: {
+          "max-size": "10m",
+          "max-file": "10"
+        }
+      }
     )
+
   end
 
   def reverse_proxy_definition_tcp

diff --git a/spec/models/heritage_task_definition_spec.rb b/spec/models/heritage_task_definition_spec.rb
@@ -11,7 +11,24 @@
       }
     }
   }
-
+  let(:expected_log_configuration_for_runpack) {
+    {
+      log_driver: "json-file",
+      options: {
+        "max-size": "10m",
+        "max-file": "10"
+      }
+    }
+  }
+  let(:expected_log_configuration_for_runpack2) {
+    {
+      "LogDriver" => "json-file",
+      "Options" => {
+        "max-size": "10m",
+        "max-file": "10"
+      }
+    }
+  }
   describe ".service_definition" do
     subject { described_class.service_definition(service).to_task_definition }
     let(:district) { create :district }
@@ -52,7 +69,7 @@
                                   essential: false,
                                   image: "public.ecr.aws/degica/barcelona-run-pack",
                                   environment: [],
-                                  log_configuration: expected_log_configuration
+                                  log_configuration: expected_log_configuration_for_runpack
                                 }
                               ]
                             })
@@ -105,7 +122,7 @@
                                     essential: false,
                                     image: "public.ecr.aws/degica/barcelona-run-pack",
                                     environment: [],
-                                    log_configuration: expected_log_configuration
+                                    log_configuration: expected_log_configuration_for_runpack
                                   },
                                   {
                                     name: "#{service.service_name}-revpro",
@@ -197,7 +214,7 @@
                                     essential: false,
                                     image: "public.ecr.aws/degica/barcelona-run-pack",
                                     environment: [],
-                                    log_configuration: expected_log_configuration
+                                    log_configuration: expected_log_configuration_for_runpack
                                   },
                                   {
                                     name: "#{service.service_name}-revpro",
@@ -283,7 +300,7 @@
                                   essential: false,
                                   image: "public.ecr.aws/degica/barcelona-run-pack",
                                   environment: [],
-                                  log_configuration: expected_log_configuration
+                                  log_configuration: expected_log_configuration_for_runpack
                                 }
                               ]
                             })
@@ -352,7 +369,7 @@
                                   "Essential" => false,
                                   "Image" => "public.ecr.aws/degica/barcelona-run-pack",
                                   "Environment" => [],
-                                  "LogConfiguration" => expected_log_configuration
+                                  "LogConfiguration" => expected_log_configuration_for_runpack2
                                 }
                               ]
                             })