Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter :redirect auth fails quietly on existing user #5

Closed
deg opened this issue Sep 25, 2017 · 4 comments
Closed

Twitter :redirect auth fails quietly on existing user #5

deg opened this issue Sep 25, 2017 · 4 comments

Comments

@deg
Copy link
Owner

deg commented Sep 25, 2017

If a user has previously logged via another authorization provider, then :redirect authorization via Twitter will fail with no error or warning.

To reproduce:

  • Delete your user from the firebase app
  • Login with github
  • Logout
  • Login with Github, redirect. You will see no error, but not be logged in.

It is likely that the best (or only) way to fix this problem is by implementing account linking. See issue #3 Link Multiple Auth Providers

@pbzdyl
Copy link
Contributor

pbzdyl commented Sep 26, 2017

For the record it looks that com.degel.re-frame-firebase/init would need to check for firebase.auth.Auth#getRedirectResult and handle the auth error in .catch.

@deg
Copy link
Owner Author

deg commented Sep 26, 2017 via email

@pbzdyl
Copy link
Contributor

pbzdyl commented Sep 26, 2017

If you don't mind I can submit a patch soon!

@deg
Copy link
Owner Author

deg commented Sep 26, 2017 via email

@deg deg closed this as completed in b4a22aa Sep 27, 2017
deg added a commit that referenced this issue Sep 27, 2017
Fixes #5: Authentication errors with redirect flow fail silently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants