Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psalm is always using PHP target version 5.6 #514

Open
defuse opened this issue Jun 17, 2023 · 0 comments
Open

psalm is always using PHP target version 5.6 #514

defuse opened this issue Jun 17, 2023 · 0 comments
Labels

Comments

@defuse
Copy link
Owner

defuse commented Jun 17, 2023

I noticed this while running it locally:

$ vendor/bin/psalm
Warning: "findUnusedBaselineEntry" will default to "true" in Psalm 6. You should explicitly enable or disable this setting.
Warning: "findUnusedCode" will default to "true" in Psalm 6. You should explicitly enable or disable this setting.

Install the opcache extension to make use of JIT on PHP 8.0+ for a 20%+ performance boost!

Target PHP version: 5.6 (inferred from composer.json).
Scanning files...
Analyzing files..

This means our CI, which attempts to run psalm for different PHP versions, is actually just doing the same thing multiple times. We need to pass in --php-version=<the PHP version>.

Edit: Actually I think it may still be doing something different for the different versions of PHP, it's at least running psalm under that version of PHP. But we probably want to be testing with different target PHP versions, right?

@defuse defuse added the bug label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant