Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner loops #21

Open
joachimwolff opened this issue Dec 3, 2020 · 0 comments
Open

Inner loops #21

joachimwolff opened this issue Dec 3, 2020 · 0 comments

Comments

@joachimwolff
Copy link
Collaborator

Inner loops run infinite time if their minCoeff does not get smaller than delta or maxCoeff greater than Delta.

https://github.com/deeptools/Knight-Ruiz-Matrix-balancing-algorithm/blob/master/src/krbalancing.cpp#L134

We need some mechanism to stop after a max number of iterations and or to check problematic matrices at initialization time.

In case the inner loop terminates, we should still return a value and not quit with exit(1) the depending software too. I need this especially in the context of single-cell Hi-C, the failure of one matrix should not influence the computation of the others by terminating the whole software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant