Fix tests

Author: deeprobin

src/libraries/System.IO.FileSystem/tests/Base/AllGetSetAttributes.cs

@@ -25,12 +25,14 @@ public void InvalidParameters()
         [Theory, MemberData(nameof(TrailingCharacters))]
         public void SetAttributes_MissingFile(char trailingChar)
         {
+            if (!CanBeReadOnly) return;
             Assert.Throws<FileNotFoundException>(() => SetAttributes(GetTestFilePath() + trailingChar, FileAttributes.ReadOnly));
         }
 
         [Theory, MemberData(nameof(TrailingCharacters))]
         public void SetAttributes_MissingDirectory(char trailingChar)
         {
+            if (!CanBeReadOnly) return;
             Assert.Throws<DirectoryNotFoundException>(() => SetAttributes(Path.Combine(GetTestFilePath(), "file" + trailingChar), FileAttributes.ReadOnly));
         }
 

src/libraries/System.IO.FileSystem/tests/Base/BaseGetSetAttributes.cs

@@ -7,6 +7,7 @@ namespace System.IO.Tests
 {
     public abstract class BaseGetSetAttributes : FileSystemTest
     {
+        protected abstract bool CanBeReadOnly { get; }
         protected abstract FileAttributes GetAttributes(string path);
         protected abstract void SetAttributes(string path, FileAttributes attributes);
 

src/libraries/System.IO.FileSystem/tests/Base/FileGetSetAttributes.cs

@@ -8,14 +8,20 @@ namespace System.IO.Tests
     // Tests that are valid for File and FileInfo
     public abstract class FileGetSetAttributes : BaseGetSetAttributes
     {
-        [Theory]
-        [InlineData(FileAttributes.ReadOnly)]
-        [InlineData(FileAttributes.Normal)]
+        [Fact]
         [PlatformSpecific(TestPlatforms.AnyUnix)]
-        public void SettingAttributes_Unix(FileAttributes attributes)
+        public void SettingAttributes_Unix_Normal()
         {
             string path = CreateItem();
-            AssertSettingAttributes(path, attributes);
+            AssertSettingAttributes(path, FileAttributes.Normal);
+        }
+
+        [ConditionalFact(nameof(CanBeReadOnly))]
+        [PlatformSpecific(TestPlatforms.AnyUnix)]
+        public void SettingAttributes_Unix_ReadOnly()
+        {
+            string path = CreateItem();
+            AssertSettingAttributes(path, FileAttributes.ReadOnly);
         }
 
         [Theory]
@@ -28,16 +34,24 @@ public void SettingAttributes_OSXAndFreeBSD(FileAttributes attributes)
         }
 
         [Theory]
-        [InlineData(FileAttributes.ReadOnly)]
         [InlineData(FileAttributes.Hidden)]
         [InlineData(FileAttributes.System)]
         [InlineData(FileAttributes.Archive)]
         [InlineData(FileAttributes.Normal)]
         [InlineData(FileAttributes.Temporary)]
+        public void SettingAttributes_Windows(FileAttributes attributes)
+        {
+            string path = CreateItem();
+            AssertSettingAttributes(path, attributes);
+        }
+
+        [Theory]
+        [InlineData(FileAttributes.ReadOnly)]
         [InlineData(FileAttributes.ReadOnly | FileAttributes.Hidden)]
         [PlatformSpecific(TestPlatforms.Windows)]
-        public void SettingAttributes_Windows(FileAttributes attributes)
+        public void SettingAttributes_Windows_ReadOnly(FileAttributes attributes)
         {
+            if (!CanBeReadOnly) return;
             string path = CreateItem();
             AssertSettingAttributes(path, attributes);
         }

src/libraries/System.IO.FileSystem/tests/DirectoryInfo/GetSetAttributes.cs

@@ -15,6 +15,7 @@ protected override string CreateItem(string path = null, [CallerMemberName] stri
         protected override DirectoryInfo CreateInfo(string path) => new DirectoryInfo(path);
         protected override void DeleteItem(string path) => Directory.Delete(path);
         protected override bool IsDirectory => true;
+        protected override bool CanBeReadOnly => true;
 
         [Theory]
         [InlineData(FileAttributes.ReadOnly)]

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes.cs

@@ -9,6 +9,7 @@ public class File_GetSetAttributes : BaseGetSetAttributes
     {
         protected override FileAttributes GetAttributes(string path) => File.GetAttributes(path);
         protected override void SetAttributes(string path, FileAttributes attributes) => File.SetAttributes(path, attributes);
+        protected override bool CanBeReadOnly => false;
 
         // Getting only throws for File, not FileInfo
         [Theory, MemberData(nameof(TrailingCharacters))]

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes_SafeFileHandle.cs

@@ -1,21 +1,30 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using Microsoft.Win32.SafeHandles;
+
 namespace System.IO.Tests
 {
-    public sealed class GetSetAttributes_SafeFileHandle : FileGetSetAttributes
+    public class GetSetAttributes_SafeFileHandle : FileGetSetAttributes
     {
+        protected virtual SafeFileHandle OpenFileHandle(string path, FileAccess fileAccess) =>
+            File.OpenHandle(
+                path,
+                FileMode.OpenOrCreate,
+                fileAccess,
+                FileShare.None);
+
+        protected override bool CanBeReadOnly => false;
+
         protected override FileAttributes GetAttributes(string path)
         {
-            using var fileHandle =
-                File.OpenHandle(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
+            using SafeFileHandle fileHandle = OpenFileHandle(path, FileAccess.Read);
             return File.GetAttributes(fileHandle);
         }
-
+        
         protected override void SetAttributes(string path, FileAttributes attributes)
         {
-            using var fileHandle =
-                File.OpenHandle(path, FileMode.Open, FileAccess.ReadWrite, FileShare.ReadWrite);
+            using SafeFileHandle fileHandle = OpenFileHandle(path, FileAccess.ReadWrite);
             File.SetAttributes(fileHandle, attributes);
         }
     }

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes_String.cs

@@ -4,9 +4,10 @@
 namespace System.IO.Tests
 {
     // Concrete class to run common file attributes tests on the File class
-    public class File_GetSetAttributes_String : FileGetSetAttributes
+    public sealed class File_GetSetAttributes_String : FileGetSetAttributes
     {
         protected override FileAttributes GetAttributes(string path) => File.GetAttributes(path);
         protected override void SetAttributes(string path, FileAttributes attributes) => File.SetAttributes(path, attributes);
+        protected override bool CanBeReadOnly => true;
     }
 }

src/libraries/System.IO.FileSystem/tests/FileInfo/GetSetAttributes.cs

@@ -7,6 +7,7 @@ namespace System.IO.Tests
 {
     public class FileInfo_GetSetAttributes : InfoGetSetAttributes<FileInfo>
     {
+        protected override bool CanBeReadOnly => true;
         protected override FileAttributes GetAttributes(string path) => new FileInfo(path).Attributes;
         protected override void SetAttributes(string path, FileAttributes attributes) => new FileInfo(path).Attributes = attributes;
         protected override FileInfo CreateInfo(string path) => new FileInfo(path);

src/libraries/System.IO.FileSystem/tests/FileInfo/GetSetAttributesCommon.cs

@@ -6,6 +6,7 @@ namespace System.IO.Tests
     // Concrete class to run common file attributes tests on the FileInfo class
     public class FileInfo_GetSetAttributesCommon : FileGetSetAttributes
     {
+        protected override bool CanBeReadOnly => true;
         protected override FileAttributes GetAttributes(string path) => new FileInfo(path).Attributes;
         protected override void SetAttributes(string path, FileAttributes attributes) => new FileInfo(path).Attributes = attributes;
     }