Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please expose (promisified) waitForReady #688

Open
FauxFaux opened this issue Nov 15, 2024 · 2 comments
Open

Please expose (promisified) waitForReady #688

FauxFaux opened this issue Nov 15, 2024 · 2 comments

Comments

@FauxFaux
Copy link

The grpc client (channel?) has a waitForReady(deadline) method, which loops around waiting for the connectivityState to go to ready.

Please expose this on channel, preferably promisified, so I don't have to copy-paste it into my codebase.

https://github.com/grpc/grpc-node/blob/master/packages/grpc-js/src/client.ts#L174-L202

@FauxFaux
Copy link
Author

I have just found waitForChannelReady, which is probably acceptable as a workaround. I completely failed to find it in the search before raising this issue.

@aikoven
Copy link
Contributor

aikoven commented Nov 18, 2024

Hi @FauxFaux!

Apparently we didn't document this function. We will fix that.

When you say "workaround", do you mean that you have some other API in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants