Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awscurl: WARN maxLength is not explicitly specified, use modelMaxLength: 512 #2339

Open
CoolFish88 opened this issue Aug 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@CoolFish88
Copy link

Description

When requesting tokens per second in benchmark metrics (-t option specified) while providing the path to the tokenizer.json file as well as a payloads dataset, aws curl return the warning: WARN maxLength is not explicitly specified, use modelMaxLength: 512

I used a vLLM engine for which OPTION_MAX_MODEL_LEN was set to a higher value than 512.

(1) Are modelMaxLength and OPTION_MAX_MODEL_LEN?
(2) Is modelMaxLength overwriting OPTION_MAX_MODEL_LEN?
(3) Are token metrics impacted by this truncation?

Remark: A "tps" metric (requests per second) is included in the benchmark response. Since "tps" is usually used as an acronym for Tokens per second within the inference domain, requests per second could benefit from another abbreviation. Does "tokenThroughput" represent in this case tokens per second?

Expected Behavior

Use model server parameter as opposed to setting it to a default value

Error Message

WARN maxLength is not explicitly specified, use modelMaxLength: 512

How to Reproduce?

TOKENIZER=<path_to_tokenizer> ./awscurl -c 1 -N 10 -X POST -n sagemaker <endpoint_url> --dataset <path_to_dataset> -H 'Content-Type: application/json' -P --connect-timeout 60 -t

@CoolFish88 CoolFish88 added the bug Something isn't working label Aug 25, 2024
@frankfliu
Copy link
Contributor

The warning is just for the awscurl tool. awscurl uses the tokenizer to calculate the number of output token.

I created a PR that allows you to configure the max length with env var: #2341

@sindhuvahinis
Copy link
Contributor

@CoolFish88 The PR is now merged. Let us know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants