Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font formatting support to table cells #1715

Open
4 tasks
dsmmcken opened this issue Jan 8, 2024 · 1 comment
Open
4 tasks

Add font formatting support to table cells #1715

dsmmcken opened this issue Jan 8, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@dsmmcken
Copy link
Contributor

dsmmcken commented Jan 8, 2024

As a I would like to have more control over text formatting within a cell. Users should be able to control whether a cell is bold, italic, underlined or strikethrough, and text alignment left, center or right. We will not support mixed rich text, the formatting will apply to the cell as whole only.

  • Bold, Italic, Underline and/or Strikethrough the value of a cell through a format_columns expression. API to proposed first.
    # format to be proposed, something along these lines though
    t = t.format_columns("x = Bold(x)")
    
  • Set Bold, Italic, Underline and/or Strikethrough conditionally using the table conditional formatting UI
    image
    note: icons will be needed for strikethrough and underline.
  • Set text alignment (left, center, right) of a cell through a format_columns expression. API to proposed first.
  • Set text alignment of a column via a table header context menu option
    image

Text alignment should follow similar formatting priority to number formatting. Where: Set in the UI on the column > Set as column expression in the query > The default alignment based on column type.

@dsmmcken dsmmcken added enhancement New feature or request triage Issue requires triage labels Jan 8, 2024
@vbabich vbabich added this to the February 2024 milestone Jan 9, 2024
@vbabich vbabich removed the triage Issue requires triage label Jan 9, 2024
dsmmcken added a commit that referenced this issue Jan 18, 2024
Adds `dhUnderline` and `dhStrikethrough` icons matching `vsBold` and
`vsItalic`.


![image](https://github.com/deephaven/web-client-ui/assets/1576283/151666d9-c7d5-457a-bf23-fa3691be46bf)

Required for #1715 conditional formatting UI.
@mofojed mofojed modified the milestones: February 2024, March 2024 Mar 12, 2024
@mofojed mofojed modified the milestones: March 2024, April 2024 Apr 12, 2024
@mofojed mofojed modified the milestones: April 2024, May 2024 May 13, 2024
@mofojed mofojed modified the milestones: May 2024, June 2024 Jun 4, 2024
@vbabich vbabich modified the milestones: June 2024, July 2024 Jul 9, 2024
@mofojed mofojed modified the milestones: July 2024, September 2024 Sep 3, 2024
@mofojed
Copy link
Member

mofojed commented Oct 29, 2024

@mattrunyon has done something similar with formatting for UITable: deephaven/deephaven-plugins#950
Would need to do something similar in IrisGrid/IrisGRidTableModelTemplate.

@mofojed mofojed modified the milestones: September 2024, October 2024 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants