Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show Deephaven output panel until first connection #130

Open
bmingles opened this issue Sep 12, 2024 · 0 comments
Open

Don't show Deephaven output panel until first connection #130

bmingles opened this issue Sep 12, 2024 · 0 comments
Assignees
@bmingles
Labels
enhancement New feature or request
Milestone
September 2024

Comments

@bmingles
Copy link
Collaborator

The Deephaven output panel automatically shows when extension starts. This is not great for cases where a user is using vscode for things other than DH. It would be better to auto show on the first DH server connection instead.
@bmingles bmingles added enhancement New feature or request triage labels Sep 12, 2024
@bmingles bmingles self-assigned this Sep 12, 2024
@bmingles bmingles mentioned this issue Sep 12, 2024
Merged
@vbabich vbabich removed the triage label Sep 18, 2024
@vbabich vbabich added this to the September 2024 milestone Sep 18, 2024
bmingles added a commit that referenced this issue Sep 18, 2024
@bmingles @mofojed
feat: Panel management (#118)
4569a36 
In this PR:
- Added a `DEEPHAVEN: PANELS` view
  - Maps connections to server variables
  - Allows clicking on variables to open panels
- Is subscribed to changes on server, so will also show variables
created outside of the extension

- Open panels now refresh when active theme changes
- Removed auto focus of output panel ([Don't show Deephaven output panel
until first connection
#130](#130) to
provide the proper fix

resolves #116

---------

Co-authored-by: Mike Bender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
September 2024
Development

No branches or pull requests
2 participants
@bmingles @vbabich