Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associating connections with files is odd #123

Open
chipkent opened this issue Sep 6, 2024 · 2 comments
Open

Associating connections with files is odd #123

chipkent opened this issue Sep 6, 2024 · 2 comments
Labels
bug Something isn't working question Further information is requested

Comments

@chipkent
Copy link
Member

chipkent commented Sep 6, 2024

DH connections are now associated with files. This is odd. What if I want to run a file against two different servers? For example, I could have one script that is always run against two servers, where each server computes half of the universe. Similarly, a script could be run against a production and a backup server.

image
@chipkent chipkent added bug Something isn't working triage labels Sep 6, 2024
@mofojed mofojed added question Further information is requested and removed triage labels Sep 10, 2024
@mofojed
Copy link
Member

mofojed commented Sep 10, 2024

This comes down to how we handle environments... we have the "Run Deephaven File"/"Run Deephaven selected lines" actions, and we don't want to prompt every time you run those if you have multiple environments. Perhaps we have an extra "Run Deephaven ... " action that allows you to select a different server, and the quick actions show the previously used server? @bmingles what do you think?
We could also show the currently associated server with the quick actions as well (and/or code lens, along with a "change server" in the code lens).

@bmingles
Copy link
Collaborator

bmingles commented Sep 10, 2024

Just to call out the existing functionality in case it isn't disoverable. Files can be moved to another connection via:

  • drag and drop or by
  • using the status bar selector and selecting a new connection.

Regarding supporting associated an editor with multiple connections, I wonder if we could do something like:

  • Add an action that shows a multi-select for selecting 1-n selections to run the editor against
  • Have it remember last selection for the editor
  • Tweak the tree views such that an editor can be associated with multiple connections. You can already add / remove them there. Would just need to have it not assume a drag and drop to another connection means to remove from previous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants