Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlightServiceGrpcImpl getFlightInfo / getSchema unauthenticated path misimplemented #6374

Open
devinrsmith opened this issue Nov 13, 2024 · 1 comment
Open

FlightServiceGrpcImpl getFlightInfo / getSchema unauthenticated path misimplemented #6374

devinrsmith opened this issue Nov 13, 2024 · 1 comment
Assignees
@nbauernfeind
Labels
bug Something isn't working grpc
Milestone
0.38.0

Comments

@devinrsmith
Copy link
Member

devinrsmith commented Nov 13, 2024 •
edited
Loading

Noticed after #6215 in #6023 that there were certain cases where RPCs were hanging in tests. These happened to be FlightServiceGrpcImpl#getFlightInfo and FlightServiceGrpcImpl#getSchema calls with unauthenticated users where the implementation returns an ExportObject in that contains an error, the service does not end up ever calling onError.

There is a partial workaround by reverting part of #6215 where the TicketRouter explicitly catches RuntimeException and re-wraps as SessionState.wrapAsFailedExport, but this is not sufficient as the TicketResolver itself may choose to wrap an exception in an ExportObject instead of throwing it.
@devinrsmith devinrsmith added bug Something isn't working triage labels Nov 13, 2024
@devinrsmith devinrsmith added this to the Triage milestone Nov 13, 2024
@devinrsmith
Copy link
Member Author

devinrsmith commented Nov 13, 2024 •
edited
Loading

The io.deephaven.server.flightsql.FlightSqlUnauthenticatedTest in #6023 can reproduce this issue.

@rcaudy rcaudy added grpc and removed triage labels Nov 13, 2024
@rcaudy rcaudy modified the milestones: Triage, 0.38.0 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbauernfeind nbauernfeind

Labels
bug Something isn't working grpc
Projects
None yet
Milestone
0.38.0
Development

No branches or pull requests
3 participants
@nbauernfeind @rcaudy @devinrsmith