Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Slack Notification Step For Adhoc #277

Open
stanbrub opened this issue Mar 27, 2024 · 0 comments
Open

Improve Slack Notification Step For Adhoc #277

stanbrub opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@stanbrub
Copy link
Collaborator

stanbrub commented Mar 27, 2024

As of now, there is a slack notification step in the remote-benchmark.yml workflow. Some categories like nightly use it to publish tables to slack at the end of a run. Others like adhoc disable it by supplying no slack token in the scale-benchmark.properties file.

Notes:

  • The slack notification step is not used for adhoc runs
  • Deephaven is installed and started whether or not the publish actually uses it

Improvements:

  • Cancel the slack publish step entirely if a category doesn't use it
  • Only install Deephaven if the specific publish uses it
    • For example, 2 categories may publish to slack but only one needs Deephaven
@stanbrub stanbrub added the enhancement New feature or request label Mar 27, 2024
@stanbrub stanbrub self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant