Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closeable on Bench Sub-objects is Confusing #183

Open
stanbrub opened this issue Oct 11, 2023 · 0 comments
Open

Closeable on Bench Sub-objects is Confusing #183

stanbrub opened this issue Oct 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@stanbrub
Copy link
Collaborator

stanbrub commented Oct 11, 2023

The Bench class, which is not AutoCloseable contains builder objects that are. This is inconsistent. Any usage of a Bench instance through the builder pattern should not expose sub-objects in such a way that they can be closed without calling the close on the Bench instance. This is not currently a major issue.

  • Have sub-object implement a local interface that provides close, and possibly other common methods, instead of Closeable.
  • Allow the Bench class to be AutoCloseable (saves a few lines of code in some cases)
@stanbrub stanbrub added the enhancement New feature or request label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant