From 0728c86f31cfb910ee488af6f7ccccd5a85c91a9 Mon Sep 17 00:00:00 2001 From: Liu Chao Date: Mon, 21 Aug 2023 15:47:00 +0800 Subject: [PATCH] [querier] Fix app_label filter - run automation test(querier_sql) pass --- server/querier/engine/clickhouse/filter.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/server/querier/engine/clickhouse/filter.go b/server/querier/engine/clickhouse/filter.go index 474c7344109..0b24090f397 100644 --- a/server/querier/engine/clickhouse/filter.go +++ b/server/querier/engine/clickhouse/filter.go @@ -888,7 +888,11 @@ func GetRemoteReadFilter(promTag, table, op, value, originFilter string, e *CHEn valueIDs = append(valueIDs, valueIDString) } valueIDFilter := strings.Join(valueIDs, ",") - filter = fmt.Sprintf("app_label_value_id_%d IN (%s)", appLabel.appLabelColumnIndex, valueIDFilter) + if valueIDFilter == "" { + filter = "1!=1" + } else { + filter = fmt.Sprintf("app_label_value_id_%d IN (%s)", appLabel.appLabelColumnIndex, valueIDFilter) + } entryValue := common.EntryValue{Time: time.Now(), Filter: filter} prometheusSubqueryCache.PrometheusSubqueryCache.Add(originFilter, entryValue) return filter, nil