Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiskDataset assumes the X field is populated, in several places #4060

Open
gehlhaarPfizer opened this issue Jul 17, 2024 · 0 comments
Open

Comments

@gehlhaarPfizer
Copy link

While it is possible to easily create a DiskDataset that does not have the X field populated, there are lots of places in the DiskDataset code that assume that it is.

There is a strong use case for being able to make DiskDataset objects with, say, just a y field. For doing inference on large datasets, it makes sense to create a DiskDataset to contain the resulting generated data, and the most reasonable place to put this is in the y field.

There are several places in the code this assumption is made; for example in get_shard() it's assumed that the X file is there. Notably, this is not checked for on DiskDataset creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant