Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dag example show genericity #5

Open
efugier opened this issue Oct 4, 2018 · 3 comments
Open

Make the dag example show genericity #5

efugier opened this issue Oct 4, 2018 · 3 comments

Comments

@efugier
Copy link

efugier commented Oct 4, 2018

To be truly usable in a wide range of situation, it needs to be generic, show the world that it is !

@efugier efugier changed the title Make the dag generic Make the dag show genericity Oct 4, 2018
@efugier efugier changed the title Make the dag show genericity Make the dag example show genericity Oct 4, 2018
@declanvk
Copy link
Owner

declanvk commented Oct 4, 2018

So would you suggest showing multiple examples that all use different data? Or using the data structure in a generic setting, for example in some algorithm like shortest path?

@declanvk
Copy link
Owner

declanvk commented Oct 4, 2018

Also, I had some thoughts about making the container not hold any data (thus removing the generic parameter), but actually returning symbolic keys that would represent the nodes in the graph.

This would decrease the complexity of the data structure, and entirely remove the need for the bimap module. If you have any thoughts on that, please let me know.

@efugier
Copy link
Author

efugier commented Oct 8, 2018

I think the more example there is the better :)

Dag are often use in settings with high performances requirements, I suggest doing whatever is best for performances !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants