Skip to content

Commit b89a49d

Browse files
committed
fix tests
1 parent fa2b830 commit b89a49d

File tree

4 files changed

+27
-22
lines changed

4 files changed

+27
-22
lines changed

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
77
"dependencies": {
88
"@actions/core": "^1.10.0",
9-
"@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-12791463180.commit-127443e.tgz",
9+
"@dcl/protocol": "https://sdk-team-cdn.decentraland.org/@dcl/protocol/branch//dcl-protocol-1.0.0-12826974654.commit-3b9cde0.tgz",
1010
"@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1",
1111
"@dcl/ts-proto": "1.153.0",
1212
"@types/fs-extra": "^9.0.12",

packages/@dcl/sdk/src/network/message-bus-sync.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export function addSyncTransport(
5353
}
5454
const peerMessages = getMessagesToSend()
5555

56-
const response = await sendBinary({ data: [], peerData: peerMessages })
56+
const response = await sendBinary({ data: peerMessages.map(($) => $.data).flat(), peerData: peerMessages })
5757
binaryMessageBus.__processMessages(response.data)
5858
transportInitialzed = true
5959
},

test/sdk/network/sync-engines.spec.ts

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import { createRendererTransport } from '../../../packages/@dcl/sdk/internal/tra
1818
import { ReadWriteByteBuffer } from '../../../packages/@dcl/ecs/src/serialization/ByteBuffer'
1919
import { readMessage } from '../../../packages/@dcl/ecs/src/serialization/crdt/message'
2020
import { EntityState, PutNetworkComponentOperation } from '../../../packages/@dcl/ecs/src'
21+
import { SendBinaryRequest, SendBinaryResponse } from '~system/CommunicationsController'
2122

2223
function defineComponents(engine: IEngine) {
2324
return {
@@ -73,15 +74,17 @@ describe('Network Parenting', () => {
7374
const messagesA: Uint8Array[] = []
7475
const messagesB: Uint8Array[] = []
7576

76-
const sendBinaryA = async (msg: { data: Uint8Array[] }) => {
77-
for (const value of msg.data) {
78-
const messageType = value.subarray(0, 1)[0]
79-
if (messageType === CommsMessage.CRDT) {
80-
const crdtMessage = value.subarray(1)
81-
intercept(crdtMessage, 'a->b')
77+
const sendBinaryA: (msg: SendBinaryRequest) => Promise<SendBinaryResponse> = async (msg) => {
78+
for (const value of msg.peerData) {
79+
for (const data of value.data) {
80+
messagesB.push(data)
81+
const messageType = data.subarray(0, 1)[0]
82+
if (messageType === CommsMessage.CRDT) {
83+
const crdtMessage = data.subarray(1)
84+
intercept(crdtMessage, 'a->b')
85+
}
8286
}
8387
}
84-
messagesB.push(...msg.data)
8588
const messages = [...messagesA].map(($) => {
8689
const senderBytes = encodeString('B')
8790
const serializedMessage = new Uint8Array($.byteLength + senderBytes.byteLength + 1)
@@ -93,16 +96,18 @@ describe('Network Parenting', () => {
9396
messagesA.length = 0
9497
return { data: messages }
9598
}
96-
const sendBinaryB = async (msg: { data: Uint8Array[] }) => {
97-
for (const value of msg.data) {
98-
const messageType = value.subarray(0, 1)[0]
99-
if (messageType === CommsMessage.CRDT) {
100-
const crdtMessage = value.subarray(1)
101-
intercept(crdtMessage, 'b->a')
99+
const sendBinaryB: (msg: SendBinaryRequest) => Promise<SendBinaryResponse> = async (msg) => {
100+
for (const value of msg.peerData) {
101+
for (const data of value.data) {
102+
messagesA.push(data)
103+
const messageType = data.subarray(0, 1)[0]
104+
if (messageType === CommsMessage.CRDT) {
105+
const crdtMessage = data.subarray(1)
106+
intercept(crdtMessage, 'b->a')
107+
}
102108
}
103109
}
104110

105-
messagesA.push(...msg.data)
106111
const messages = [...messagesB].map(($) => {
107112
const senderBytes = encodeString('A')
108113
const serializedMessage = new Uint8Array($.byteLength + senderBytes.byteLength + 1)

0 commit comments

Comments
 (0)