dev: remove workaround for deleting the member

[dec0dOS]

Deprecate workaround for this:
zerotier/ZeroTierOne#859
as It was fixed in
zerotier/ZeroTierOne@f8ea7fd

More info:

zero-ui/backend/services/member.js

Lines 173 to 192 in 559a988

	export async function deleteMemberAdditionalData(nwid, mid) {
	// ZT controller bug
	/* db.get("networks")
	.find({ id: nwid })
	.get("members")
	.remove({ id: mid })
	.write();
	*/
	await updateMemberAdditionalData(nwid, mid, {});
	db.get("networks")
	.filter({ id: nwid })
	.map("members")
	.first()
	.filter({ id: mid })
	.first()
	.set("deleted", true)
	.write();
	}

[wongsyrone]

How about this block

zero-ui/backend/routes/member.js

Lines 72 to 86 in 559a988

	// Need this to fix ZT controller bug https://github.com/zerotier/ZeroTierOne/issues/859
	const defaultConfig = {
	authorized: false,
	ipAssignments: [],
	capabilities: [],
	tags: [],
	};
	api
	.post("controller/network/" + nwid + "/member/" + mid, defaultConfig)
	.then(function (controllerRes) {
	res.status(controllerRes.status).send("");
	})
	.catch(function (err) {
	res.status(500).send({ error: err.message });
	});

[dec0dOS]

@wongsyrone, thanks for pointing! This one is also affected.

[wongsyrone]

Another quick thought, my db.json left many zt nodes with deleted set to true, it's better to clean up these leftovers on zero-ui startup. The proposed workflow is to do the member deletion but ignore controller response and delete additional member data and the member entry in db.json.

[dec0dOS]

Currently, I'm still thinking for the proper migrations solution for ZeroUI: #75