Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible TIGCCLIB change (default.h inclusion removal) #2

Open
kkofler opened this issue Oct 2, 2013 · 0 comments
Open

Incompatible TIGCCLIB change (default.h inclusion removal) #2

kkofler opened this issue Oct 2, 2013 · 0 comments

Comments

@kkofler
Copy link

kkofler commented Oct 2, 2013

Commit 4b9c4b5 breaks backwards compatibility!
Minimal test case:

#define USE_TI89
#include <float.h>

void _main(void)
{
}

This compiles with the real TIGCC, but will produce a "No target calculators specified" error after the above commit.

One of the basic principles of TIGCCLIB is that all headers include <default.h>, so that users can rely on the fact that including any TIGCCLIB header is enough to apply options, without having to check on a case-to-case basis whether that actually holds for any particular header. So Lionel's commit is totally user-unfriendly, in addition to being incompatible. But even just the incompatibility would render it unacceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant