Codecov Report

Attention: Patch coverage is 29.62963% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (a538092) to head (b49184d).
Report is 121 commits behind head on develop.

@@             Coverage Diff             @@
##           develop    #1092      +/-   ##
===========================================
- Coverage    79.84%   79.72%   -0.13%     
===========================================
  Files          109      109              
  Lines        11651    11678      +27     
===========================================
+ Hits          9303     9310       +7     
- Misses        2348     2368      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanMayo This all seems to be working now, based on tests on my Windows machine, but I'd appreciate you testing it too.

To test, you will need to do something like this on a Windows machine:

1. Copy your Pepys Install folder to another folder somewhere called something like network-pepys. This will be the fake network copy that we'll be comparing to, and copying from.
2. Modify the __init__.py file inside the pepys_import folder in this copy to change the version number to something higher than the current (eg. 1.0.0)
3. Modify the Pepys config file so that there is a new section like this at the end

[network]
master_install_path = c:\network-pepys

(replace the path with the path to your fake network version)
4. Run Pepys Admin or Pepys Import, you should get an error saying that the network version is newer.
5. Run Upgrade Pepys from the Start Menu. It should say that it is copying from the fake network location, and then print out a list of files it is copying as it copies them.
6. Run Pepys Admin again, and you should see that it has been upgraded to the new version - with the new version number displayed in the welcome banner.

Can you have a go and let me know how you get on. Once you've confirmed it is working, we'll need to work with the clients to get it working on their system, with the config file set up correctly etc.

@robintw - did you consider deleting some (or all) local files before copying the new ones over?

If we rename a source-code file in Pepys, the previous one will still be there. This could be relevant for importers - since a previous (broken) one may still be present in the folder, and get used.

Clearly if an analyst puts their own importer in the folder, or modifies an official version they'll lose their changes. I've just looked, but didn't find any documentation on a 'user' importer folder - where locally developed importers would be stored. Do you remember that at all?

@IanMayo Good point.

I've updated the PR so that it now deletes the contents of the folder before copying the new version across. I've tested it and it works. You'll see from the code that it deletes things in a couple of steps, as Powershell/cmd.exe seems to want to keep hold of the bin folder even when you change directory out of it. We get around that by not actually deleting the bin folder, just deleting all the other folders, and then deleting the contents of the bin folder but not the folder itself. Seems to work fine.

This just worked fine, thanks @robintw. The wrong version was identified. When I ran Upgrade Pepys - it deleted the local instance (taking almost a minute to delete the Python folder), then copied in the new version.

One issue, we have mixed language: the CLI advises me to run the Update Pepys program, but the item in the Start Menu is called Upgrade Pepys.

I'll modify the CLI message.