Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why not pure rust with zip-rs? #16

Open
JoelMon opened this issue Jul 19, 2022 · 5 comments
Open

Question: Why not pure rust with zip-rs? #16

JoelMon opened this issue Jul 19, 2022 · 5 comments

Comments

@JoelMon
Copy link

JoelMon commented Jul 19, 2022

Hello,

Out of curiosity I would like to ask why use TS for the zipping when there are Rust crates like zip-rs for zipping?

Just curious.

@YassinEldeeb
Copy link
Member

YassinEldeeb commented Oct 12, 2022

Oh, sorry for the delay. didn't see that earlier. So it was just for simplicity's sake, TypeScript scripts are way easier and faster to write than Rust and also easier to execute while for rust I'd have to make sure I build the binary first and then use it but for TS I just use ts-node zipper.ts. I had 10 days as a deadline to finish this project so choosing TS for publishment utilities was a wise choice at least for me(cause I've been using TS for 5y while Rust for a few months), cause it speed up the process.

@JoelMon
Copy link
Author

JoelMon commented Oct 13, 2022

That makes perfect sense. Thank you for getting back to me.

Would a rust implementation now be something you would be interested in if I make it happen or do you prefer to keep it the way it is?

@YassinEldeeb
Copy link
Member

I'd love to, and I'll be happy to review and merge your PR. Rust everything - Rust for the win!

@JoelMon
Copy link
Author

JoelMon commented Oct 14, 2022

Woot! Sounds like a win! I'm working on a few things at the moment but if no one gets to it before I do, I would like to take a crack at it.

@YassinEldeeb
Copy link
Member

Yeah, sure and Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants