Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging #65

Open
deadbits opened this issue Nov 28, 2023 · 2 comments
Open

Better logging #65

deadbits opened this issue Nov 28, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request logging Logging

Comments

@deadbits
Copy link
Owner

Review logging across the application and standardize to a common format that's conducive to key-value extraction.

I'm thinking two main loggers:

  • Application logs (database, loading and running scanners, etc)
  • Results (final scan results)

Right now, the final scan results are returned via API or as a dict in the Python library but not logged anywhere.

Logging should also be configurable; whether to log to a file or not, log results or not.

@deadbits deadbits added enhancement New feature or request logging Logging labels Nov 28, 2023
@deadbits deadbits self-assigned this Nov 28, 2023
@deadbits
Copy link
Owner Author

This also raises the question of whether or not Vigil should returned the submitted prompt/response in the results, because it will then be reflected in the logs.

Same goes for the vector db scanner matches. High likelihood for bad content that's probably best not to ingest through logs.

Right now the logs do contain strings like this, but it's meant more for debugging / research purposes. Maybe a flag in the config to choose to log unsafe strings or not.

@deadbits
Copy link
Owner Author

And less verbose. There's lots of informational messages that should be debug messages or not present at all. Other messages could be consolidated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logging Logging
Projects
None yet
Development

No branches or pull requests

1 participant