Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for add_ci() with tbl_summary(percent = 'row') #1929

Closed
ddsjoberg opened this issue Aug 26, 2024 · 6 comments · Fixed by #2116
Closed

Feature request: Add support for add_ci() with tbl_summary(percent = 'row') #1929

ddsjoberg opened this issue Aug 26, 2024 · 6 comments · Fixed by #2116
Milestone

Comments

@ddsjoberg
Copy link
Owner

We will also need to support add_ci.tbl_svysummary()

@ddsjoberg
Copy link
Owner Author

I started implementing this in add_ci.tbl_summary(). In the current construct, 'cell' would be pretty tricky to implement, but 'row' is somewhat reasonable...but requires some gross manipulation to the current code.

This would be best implemented in cardx::ard_categorical_ci(). I've opened an issue here insightsengineering/cardx#204

@elizn9
Copy link

elizn9 commented Nov 27, 2024

Any timeframe on this? This used to work (add_ci with percent=cell) in an older version of tbl_summary (1.7.2) but is no longer. I have several workflows that used this to generate row-wise confidence intervals and have not been able to get a backwards compatible installation of R/all my libraries to use the older version. Thank you - I love this package and use it extensively.

@ddsjoberg
Copy link
Owner Author

Hi @elizn9 , I didn't realize that functionality was available in the earlier version. 😬 I'll get to this when i can, but I honestly don't know when I'll have the bandwidth.

In the meantime, I recommend using {renv} to ensure your projects use the needed versions of packages. You can also use tools like Posit Package Manager which has dated archive of all CRAN packages. You can easily install older versions as needed https://packagemanager.posit.co/client/#/repos/cran/setup?snapshot=2024-02-01

@elizn9
Copy link

elizn9 commented Dec 11, 2024

Hi @ddsjoberg - Thanks for the response. Unfortunately package management is not possible when working on externally managed servers that host R (and update libraries on an adhoc basis). But, I figured out a workaround using tbl_custom_summary to build proportion tables and then merging them all together. It's less elegant, but gets what I need. But when/if you get to it, it would be much appreciated. It definitely worked in the previous (pre 2.0) version. Thanks!

@ddsjoberg ddsjoberg changed the title Feature request: Add support for add_ci() with tbl_summary(percent = c('row', 'cell')) Feature request: Add support for add_ci() with tbl_summary(percent = 'row') Dec 20, 2024
@ddsjoberg ddsjoberg added this to the v2.1.0 milestone Jan 4, 2025
@ddsjoberg
Copy link
Owner Author

ddsjoberg commented Jan 6, 2025

@elizn9 I have a pull request prepared to implement this functionality. Can you please install this version and give it a try before it's added to the package? You can install it with: pak::pkg_install("ddsjoberg/gtsummary@1929-add_ci-denom", dependencies = TRUE)

@elizn9
Copy link

elizn9 commented Jan 6, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@ddsjoberg @elizn9 and others