Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we just depend on any opencv-python version (or none at all) ? #34

Open
moooeeeep opened this issue Dec 12, 2022 · 1 comment
Open

Comments

@moooeeeep
Copy link

Is there a reason this package depends on these old but oddly specific versions of opencv-python and av?

install_requires=['netifaces', 'opencv-python==4.2.0.32', 'av==8.0.3'],

If not, I'd like to suggest to widen / remove the version specifiers.

As both deps are also not even imported in the installed package, maybe we could drop those entries from the setup.py altogether, and add a requirements.txt to the apps folder maybe?

@ddetommaso
Copy link
Owner

Hi @moooeeeep ,

thank you for the feedback and suggestion. Those requirements allow the provided examples to run smoothly.
I agree with you, for the controller itself it would be nice to minimize the requirements to those really necessary.

I leave the issue open, to keep track of future developments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants