Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow for pull requests? #215

Open
friederschueler opened this issue Jun 23, 2017 · 2 comments
Open

Workflow for pull requests? #215

friederschueler opened this issue Jun 23, 2017 · 2 comments

Comments

@friederschueler
Copy link

friederschueler commented Jun 23, 2017 •
edited
Loading

Hi,

I implemented a small, but (for me) important feature. I made a pull request, but I don't know the workflow. Is there anyone I can ask for review? Do I have to create a seperate issue mentioning the pull request?
Do I just wait?

The pull request is: #214
@G07cha
Copy link

G07cha commented Jul 4, 2017

Hi @friederschueler, last merged commit to master branch was half a year ago so seems like repository owner isn't actively maintaining this project anymore. You can reach him via email though.

Also since it is open-source and this project has MIT license you are able to work on your own fork, merge a PR in it and publish as a npm package if you want to.

@friederschueler
Copy link
Author

@G07cha I wrote him an email, but no response yet.

@dchester triggering notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@friederschueler @G07cha