Disable median for now.

Author: dcherian

xarray/core/_aggregations.py

@@ -3606,30 +3606,14 @@ def median(
         Data variables:
             da       (labels) float64 24B nan 2.0 1.5
         """
-        if (
-            flox_available
-            and OPTIONS["use_flox"]
-            and module_available("flox", minversion="0.9.2")
-            and contains_only_chunked_or_numpy(self._obj)
-        ):
-            return self._flox_reduce(
-                func="median",
-                dim=dim,
-                skipna=skipna,
-                numeric_only=True,
-                # fill_value=fill_value,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
-        else:
-            return self._reduce_without_squeeze_warn(
-                duck_array_ops.median,
-                dim=dim,
-                skipna=skipna,
-                numeric_only=True,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
+        return self._reduce_without_squeeze_warn(
+            duck_array_ops.median,
+            dim=dim,
+            skipna=skipna,
+            numeric_only=True,
+            keep_attrs=keep_attrs,
+            **kwargs,
+        )
 
     def cumsum(
         self,
@@ -5123,30 +5107,14 @@ def median(
         Data variables:
             da       (time) float64 24B 1.0 2.0 nan
         """
-        if (
-            flox_available
-            and OPTIONS["use_flox"]
-            and module_available("flox", minversion="0.9.2")
-            and contains_only_chunked_or_numpy(self._obj)
-        ):
-            return self._flox_reduce(
-                func="median",
-                dim=dim,
-                skipna=skipna,
-                numeric_only=True,
-                # fill_value=fill_value,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
-        else:
-            return self._reduce_without_squeeze_warn(
-                duck_array_ops.median,
-                dim=dim,
-                skipna=skipna,
-                numeric_only=True,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
+        return self._reduce_without_squeeze_warn(
+            duck_array_ops.median,
+            dim=dim,
+            skipna=skipna,
+            numeric_only=True,
+            keep_attrs=keep_attrs,
+            **kwargs,
+        )
 
     def cumsum(
         self,
@@ -6541,28 +6509,13 @@ def median(
         Coordinates:
           * labels   (labels) object 24B 'a' 'b' 'c'
         """
-        if (
-            flox_available
-            and OPTIONS["use_flox"]
-            and module_available("flox", minversion="0.9.2")
-            and contains_only_chunked_or_numpy(self._obj)
-        ):
-            return self._flox_reduce(
-                func="median",
-                dim=dim,
-                skipna=skipna,
-                # fill_value=fill_value,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
-        else:
-            return self._reduce_without_squeeze_warn(
-                duck_array_ops.median,
-                dim=dim,
-                skipna=skipna,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
+        return self._reduce_without_squeeze_warn(
+            duck_array_ops.median,
+            dim=dim,
+            skipna=skipna,
+            keep_attrs=keep_attrs,
+            **kwargs,
+        )
 
     def cumsum(
         self,
@@ -7949,28 +7902,13 @@ def median(
         Coordinates:
           * time     (time) datetime64[ns] 24B 2001-01-31 2001-04-30 2001-07-31
         """
-        if (
-            flox_available
-            and OPTIONS["use_flox"]
-            and module_available("flox", minversion="0.9.2")
-            and contains_only_chunked_or_numpy(self._obj)
-        ):
-            return self._flox_reduce(
-                func="median",
-                dim=dim,
-                skipna=skipna,
-                # fill_value=fill_value,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
-        else:
-            return self._reduce_without_squeeze_warn(
-                duck_array_ops.median,
-                dim=dim,
-                skipna=skipna,
-                keep_attrs=keep_attrs,
-                **kwargs,
-            )
+        return self._reduce_without_squeeze_warn(
+            duck_array_ops.median,
+            dim=dim,
+            skipna=skipna,
+            keep_attrs=keep_attrs,
+            **kwargs,
+        )
 
     def cumsum(
         self,

xarray/util/generate_aggregations.py

@@ -442,9 +442,9 @@ def generate_code(self, method, has_keep_attrs):
         if self.datastructure.numeric_only:
             extra_kwargs.append(f"numeric_only={method.numeric_only},")
 
-        # numpy_groupies & flox do not support median
-        # https://github.com/ml31415/numpy-groupies/issues/43
-        method_is_not_flox_supported = method.name in ("cumsum", "cumprod")
+        # median isn't enabled yet, because it would break if a single group was present in multiple
+        # chunks. The non-flox code path will just rechunk every group to a single chunk and execute the median
+        method_is_not_flox_supported = method.name in ("median", "cumsum", "cumprod")
         if method_is_not_flox_supported:
             indent = 12
         else: