Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-2194] Conversion metrics cannot render queries with filters unless the element is in the group by #1210

Closed
Tracked by #1213
tlento opened this issue May 14, 2024 · 0 comments · Fixed by #1381
Closed
Tracked by #1213
Assignees
Labels
Medium priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync

Comments

@tlento
Copy link
Contributor

tlento commented May 14, 2024

In adding rendering tests for conversion metrics I noticed that a query like the following will raise an exception:

    query_spec = query_parser.parse_and_validate_query(
        metric_names=("visit_buy_conversion_rate",),
        group_by_names=("visit__referrer_id",),
        where_constraint=PydanticWhereFilter(
            where_sql_template=("{{ TimeDimension('metric_time', 'day') }} = '2020-01-01'")
        ),
    )

This fails with the following error:

AssertionError: All parent nodes should have the same set of linkable instances since all values are coalesced.

This is in the dataflow to sql query plan converter. It's possible this is due to removing filter specs from the conversion metric query as detailed in #1199 but as this may not be related I'm opening a separate issue for investigation.

SL-2194

@tlento tlento changed the title Conversion metrics cannot render queries with filters unless the element is in the group by [SL-2194] Conversion metrics cannot render queries with filters unless the element is in the group by May 14, 2024
@tlento tlento added the Metricflow Created by Linear-GitHub Sync label May 16, 2024
@tlento tlento self-assigned this May 16, 2024
@tlento tlento added the Medium priority Created by Linear-GitHub Sync label May 16, 2024
@tlento tlento added this to the v.42 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant