From 2dbc0adf3d9d5dc1e86a2c4989713c658b38d770 Mon Sep 17 00:00:00 2001 From: Will Deng Date: Tue, 15 Oct 2024 13:11:19 -0400 Subject: [PATCH] Update snapshots --- ...resolves_to_shortest_entity_path_item__result_0.txt | 2 +- ...test_resolvable_ambiguous_entity_path__result_0.txt | 2 +- ...onversion_rate_with_constant_properties__result.txt | 7 ++++++- ...etric_with_defined_metric_time_filter__result_0.txt | 7 ++++++- ...ed_metric_time_filter_on_input_metric__result_0.txt | 7 ++++++- ...metric_with_explicit_time_granularity__result_0.txt | 2 +- ...ric_without_explicit_time_granularity__result_0.txt | 7 ++++++- ...tric_time_ignores_default_granularity__result_0.txt | 2 +- ...etric_with_defined_metric_time_filter__result_0.txt | 7 ++++++- ...metric_with_explicit_time_granularity__result_0.txt | 2 +- ...ric_without_explicit_time_granularity__result_0.txt | 2 +- ...tric_agg_time_dimension_name_validation__result.txt | 2 +- ...test_derived_metric_with_offset_parsing__result.txt | 2 +- .../test_order_by_granularity_conversion__result.txt | 5 ++++- ...test_order_by_granularity_no_conversion__result.txt | 2 +- ...arse_and_validate_where_constraint_dims__result.txt | 2 +- .../ParseQueryResult/test_query_parser__result.txt | 10 ++++++++-- ...ry_parser_case_insensitivity_with_names__result.txt | 10 ++++++++-- ...se_insensitivity_with_parameter_objects__result.txt | 10 ++++++++-- .../test_query_parser_with_object_params__result.txt | 10 ++++++++-- .../test_time_range_constraint_conversion__result.txt | 5 ++++- 21 files changed, 80 insertions(+), 25 deletions(-) diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_ambiguous_entity_path_resolves_to_shortest_entity_path_item__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_ambiguous_entity_path_resolves_to_shortest_entity_path_item__result_0.txt index 202bece9e0..02a490720d 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_ambiguous_entity_path_resolves_to_shortest_entity_path_item__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_ambiguous_entity_path_resolves_to_shortest_entity_path_item__result_0.txt @@ -1,5 +1,5 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='all_entity_metric'),), + metric_specs=(MetricSpec(element_name='all_entity_metric', filter_spec_set=WhereFilterSpecSet()),), dimension_specs=(DimensionSpec(element_name='country', entity_links=(EntityReference(element_name='entity_1'),)),), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp(), diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_resolvable_ambiguous_entity_path__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_resolvable_ambiguous_entity_path__result_0.txt index cd062bfdee..621d7f1a43 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_resolvable_ambiguous_entity_path__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_ambiguous_entity_path.py/MetricFlowQuerySpec/test_resolvable_ambiguous_entity_path__result_0.txt @@ -1,5 +1,5 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='entity_1_metric'),), + metric_specs=(MetricSpec(element_name='entity_1_metric', filter_spec_set=WhereFilterSpecSet()),), dimension_specs=( DimensionSpec( element_name='country', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_conversion_metrics.py/ParseQueryResult/test_conversion_rate_with_constant_properties__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_conversion_metrics.py/ParseQueryResult/test_conversion_rate_with_constant_properties__result.txt index c898b56f44..79b981a90d 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_conversion_metrics.py/ParseQueryResult/test_conversion_rate_with_constant_properties__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_conversion_metrics.py/ParseQueryResult/test_conversion_rate_with_constant_properties__result.txt @@ -1,6 +1,11 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='visit_buy_conversion_rate_by_session'),), + metric_specs=( + MetricSpec( + element_name='visit_buy_conversion_rate_by_session', + filter_spec_set=WhereFilterSpecSet(), + ), + ), dimension_specs=( DimensionSpec( element_name='referrer_id', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter__result_0.txt index d3104131e6..c0a5ff91dc 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter__result_0.txt @@ -1,5 +1,10 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='derived_metric_with_time_granularity_and_outer_metric_time_filter'),), + metric_specs=( + MetricSpec( + element_name='derived_metric_with_time_granularity_and_outer_metric_time_filter', + filter_spec_set=WhereFilterSpecSet(), + ), + ), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp( spec_resolutions=( diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter_on_input_metric__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter_on_input_metric__result_0.txt index a5fd895e42..9a7182e743 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter_on_input_metric__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_defined_metric_time_filter_on_input_metric__result_0.txt @@ -1,5 +1,10 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='derived_metric_with_time_granularity_and_inner_metric_time_filter'),), + metric_specs=( + MetricSpec( + element_name='derived_metric_with_time_granularity_and_inner_metric_time_filter', + filter_spec_set=WhereFilterSpecSet(), + ), + ), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp( spec_resolutions=( diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_explicit_time_granularity__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_explicit_time_granularity__result_0.txt index 58dc086594..fd25d23aa1 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_explicit_time_granularity__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_with_explicit_time_granularity__result_0.txt @@ -1,5 +1,5 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='derived_metric_with_time_granularity'),), + metric_specs=(MetricSpec(element_name='derived_metric_with_time_granularity', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_without_explicit_time_granularity__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_without_explicit_time_granularity__result_0.txt index ff0b339306..c92027c4bc 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_without_explicit_time_granularity__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_derived_metric_without_explicit_time_granularity__result_0.txt @@ -1,5 +1,10 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='derived_metric_without_time_granularity'),), + metric_specs=( + MetricSpec( + element_name='derived_metric_without_time_granularity', + filter_spec_set=WhereFilterSpecSet(), + ), + ), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_non_metric_time_ignores_default_granularity__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_non_metric_time_ignores_default_granularity__result_0.txt index c4864012a5..4672054bd0 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_non_metric_time_ignores_default_granularity__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_non_metric_time_ignores_default_granularity__result_0.txt @@ -1,5 +1,5 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='largest_listing'),), + metric_specs=(MetricSpec(element_name='largest_listing', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='ds', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_defined_metric_time_filter__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_defined_metric_time_filter__result_0.txt index 2bbdd3b918..077142a05a 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_defined_metric_time_filter__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_defined_metric_time_filter__result_0.txt @@ -1,5 +1,10 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='simple_metric_with_default_time_granularity_and_metric_time_filter'),), + metric_specs=( + MetricSpec( + element_name='simple_metric_with_default_time_granularity_and_metric_time_filter', + filter_spec_set=WhereFilterSpecSet(), + ), + ), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp( spec_resolutions=( diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_explicit_time_granularity__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_explicit_time_granularity__result_0.txt index b9e283b935..663138786e 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_explicit_time_granularity__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_with_explicit_time_granularity__result_0.txt @@ -1,5 +1,5 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='largest_listing'),), + metric_specs=(MetricSpec(element_name='largest_listing', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_without_explicit_time_granularity__result_0.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_without_explicit_time_granularity__result_0.txt index d848239171..9b7b10399c 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_without_explicit_time_granularity__result_0.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_metric_time_granularity.py/MetricFlowQuerySpec/test_simple_metric_without_explicit_time_granularity__result_0.txt @@ -1,5 +1,5 @@ MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='monthly_metric_0'),), + metric_specs=(MetricSpec(element_name='monthly_metric_0', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_cumulative_metric_agg_time_dimension_name_validation__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_cumulative_metric_agg_time_dimension_name_validation__result.txt index ec8d7bf0a9..a9e169caa3 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_cumulative_metric_agg_time_dimension_name_validation__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_cumulative_metric_agg_time_dimension_name_validation__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='revenue_cumulative'),), + metric_specs=(MetricSpec(element_name='revenue_cumulative', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='ds', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_derived_metric_with_offset_parsing__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_derived_metric_with_offset_parsing__result.txt index 692c379b99..67c2e3cc2a 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_derived_metric_with_offset_parsing__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_derived_metric_with_offset_parsing__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='revenue_growth_2_weeks'),), + metric_specs=(MetricSpec(element_name='revenue_growth_2_weeks', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_conversion__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_conversion__result.txt index 87ca579f36..6b4bc38888 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_conversion__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_conversion__result.txt @@ -1,6 +1,9 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'), MetricSpec(element_name='revenue')), + metric_specs=( + MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()), + MetricSpec(element_name='revenue', filter_spec_set=WhereFilterSpecSet()), + ), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_no_conversion__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_no_conversion__result.txt index 526506e5c3..659b8ae592 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_no_conversion__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_order_by_granularity_no_conversion__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'),), + metric_specs=(MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_parse_and_validate_where_constraint_dims__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_parse_and_validate_where_constraint_dims__result.txt index 5506daedf7..f275d1d490 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_parse_and_validate_where_constraint_dims__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_parse_and_validate_where_constraint_dims__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'),), + metric_specs=(MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()),), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time', diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser__result.txt index 14216fc428..b20696dc79 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'),), + metric_specs=(MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()),), dimension_specs=( DimensionSpec( element_name='is_instant', @@ -25,7 +25,13 @@ ParseQueryResult( ), descending=False, ), - OrderBySpec(instance_spec=MetricSpec(element_name='bookings'), descending=True), + OrderBySpec( + instance_spec=MetricSpec( + element_name='bookings', + filter_spec_set=WhereFilterSpecSet(), + ), + descending=True, + ), ), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp(), diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_names__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_names__result.txt index 14216fc428..b20696dc79 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_names__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_names__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'),), + metric_specs=(MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()),), dimension_specs=( DimensionSpec( element_name='is_instant', @@ -25,7 +25,13 @@ ParseQueryResult( ), descending=False, ), - OrderBySpec(instance_spec=MetricSpec(element_name='bookings'), descending=True), + OrderBySpec( + instance_spec=MetricSpec( + element_name='bookings', + filter_spec_set=WhereFilterSpecSet(), + ), + descending=True, + ), ), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp(), diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_parameter_objects__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_parameter_objects__result.txt index 14216fc428..b20696dc79 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_parameter_objects__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_case_insensitivity_with_parameter_objects__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'),), + metric_specs=(MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()),), dimension_specs=( DimensionSpec( element_name='is_instant', @@ -25,7 +25,13 @@ ParseQueryResult( ), descending=False, ), - OrderBySpec(instance_spec=MetricSpec(element_name='bookings'), descending=True), + OrderBySpec( + instance_spec=MetricSpec( + element_name='bookings', + filter_spec_set=WhereFilterSpecSet(), + ), + descending=True, + ), ), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp(), diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_with_object_params__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_with_object_params__result.txt index 14216fc428..b20696dc79 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_with_object_params__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_query_parser_with_object_params__result.txt @@ -1,6 +1,6 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'),), + metric_specs=(MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()),), dimension_specs=( DimensionSpec( element_name='is_instant', @@ -25,7 +25,13 @@ ParseQueryResult( ), descending=False, ), - OrderBySpec(instance_spec=MetricSpec(element_name='bookings'), descending=True), + OrderBySpec( + instance_spec=MetricSpec( + element_name='bookings', + filter_spec_set=WhereFilterSpecSet(), + ), + descending=True, + ), ), filter_intersection=PydanticWhereFilterIntersection(), filter_spec_resolution_lookup=FilterSpecResolutionLookUp(), diff --git a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_time_range_constraint_conversion__result.txt b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_time_range_constraint_conversion__result.txt index 95cab878bd..7d0bb5bcee 100644 --- a/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_time_range_constraint_conversion__result.txt +++ b/metricflow-semantics/tests_metricflow_semantics/snapshots/test_query_parser.py/ParseQueryResult/test_time_range_constraint_conversion__result.txt @@ -1,6 +1,9 @@ ParseQueryResult( query_spec=MetricFlowQuerySpec( - metric_specs=(MetricSpec(element_name='bookings'), MetricSpec(element_name='revenue')), + metric_specs=( + MetricSpec(element_name='bookings', filter_spec_set=WhereFilterSpecSet()), + MetricSpec(element_name='revenue', filter_spec_set=WhereFilterSpecSet()), + ), time_dimension_specs=( TimeDimensionSpec( element_name='metric_time',