Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalidate_hard_deletes missing from snapshot configurations #6405

Closed
1 task done
alison985 opened this issue Nov 3, 2024 · 1 comment · Fixed by #6407
Closed
1 task done

invalidate_hard_deletes missing from snapshot configurations #6405

alison985 opened this issue Nov 3, 2024 · 1 comment · Fixed by #6407
Assignees
@mirnawong1
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@alison985
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/snapshot-configs

What part(s) of the page would you like to see updated?

The specification does not include invalidate_hard_deletes as an option. It seems like it was not integrated in. As a reference page it should show all the options.

Additional information

This topic is covered here: https://docs.getdbt.com/reference/resource-configs/invalidate_hard_deletes
@alison985 alison985 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Nov 3, 2024
mirnawong1 added a commit that referenced this issue Nov 4, 2024
@mirnawong1
adds invalidate_hard_deletes from snapshot configs page
fc272e5 
this pr adds `invalidates_hard_deletes` to the snapshot configs page. it also removes `snapshot_meta_column_names` from the project yaml tab as it's avail in 1.9 and higher, not 1.8.

Resolves #6405
@mirnawong1 mirnawong1 mentioned this issue Nov 4, 2024
Merged
@mirnawong1 mirnawong1 self-assigned this Nov 4, 2024
@mirnawong1
Copy link
Contributor

hey @alison985, thanks for opening this issue and flagging this to us! we've gone ahead and updated the doc to add this back in - really appreciate your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds invalidate_hard_deletes from snapshot configs page dbt-labs/docs.getdbt.com
2 participants
@alison985 @mirnawong1