Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Allow generic tests to accept arbitrary configs #5548

Closed
McKnight-42 opened this issue May 22, 2024 · 7 comments · Fixed by #5679
Closed

[Core] Allow generic tests to accept arbitrary configs #5548

McKnight-42 opened this issue May 22, 2024 · 7 comments · Fixed by #5679
Assignees
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 external-adapters-team auto labeled issues from the adapter team improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@McKnight-42
Copy link
Contributor

McKnight-42 commented May 22, 2024

Link to the page(s) on docs.getdbt.com requiring updates

tbd

Tell us more about this update

We will want to update our tests configs to be able to take whatever config the user wants to set as we do for eg. models
An example of an appropriate config that would benefit from this would be snowflake_warehouse so that users can define the virtual warehouse they use for tests in Snowflake.

Reviewers/Stakeholders/SMEs

adapters team (Matthew McKnight)

Related GitHub issues

Additional information

No response

@McKnight-42 McKnight-42 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels May 22, 2024
@McKnight-42 McKnight-42 self-assigned this May 22, 2024
@nghi-ly nghi-ly added the external-adapters-team auto labeled issues from the adapter team label May 22, 2024
@nghi-ly nghi-ly self-assigned this May 22, 2024
@McKnight-42
Copy link
Contributor Author

McKnight-42 commented Jun 12, 2024

I believe around here would be the place to make the change https://docs.getdbt.com/reference/data-test-configs#data-test-specific-configurations as this is where we define the Data-test specific and Generic configs for tests.

possibly want to add an example here https://docs.getdbt.com/reference/data-test-configs#examples

showing we can add any config.

models:
  - name: my_model
    columns:
      - name: id
        tests:
          - unique:
          - config:
             custom_config: custom_value

@McKnight-42
Copy link
Contributor Author

McKnight-42 commented Jun 17, 2024

@jtcohen6 is this the appropriate place to update?

@nghi-ly
Copy link
Contributor

nghi-ly commented Jun 18, 2024

@jtcohen6 in addition to the links matt provided for updating, should the following sections also be updated?

@nghi-ly
Copy link
Contributor

nghi-ly commented Jun 28, 2024

hey @matthewshaver :

hand-off heads up: when i last synced with @McKnight-42 , he was gonna investigate further on what needs to be documented/updated and circle back with some guidance

@dbeatty10
Copy link
Contributor

Re-opening since #5679 was reverted by #5901.

@dbeatty10 dbeatty10 reopened this Aug 30, 2024
@dbeatty10
Copy link
Contributor

Closing as "not planned" in favor of re-opening or creating a new issue once this feature is re-implemented.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@dbeatty10 dbeatty10 changed the title [Core] Docs Changes needed from dbt-core Issue #10197 [Core] Allow generic tests to accept arbitrary configs Oct 4, 2024
@dbeatty10
Copy link
Contributor

#6274 is the newest issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 external-adapters-team auto labeled issues from the adapter team improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants