Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for unit testing incremental models #4929

Closed
1 task done
graciegoheen opened this issue Feb 15, 2024 · 2 comments · Fixed by #4959
Closed
1 task done

Docs for unit testing incremental models #4929

graciegoheen opened this issue Feb 15, 2024 · 2 comments · Fixed by #4959
Assignees
Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear unit testing docs for 1.8 unit testing

Comments

@graciegoheen
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

New section on this page
https://docs.getdbt.com/docs/build/unit-tests

What part(s) of the page would you like to see updated?

New section on unit testing incremental models

Additional information

No response

@graciegoheen graciegoheen added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt-core v1.8 unit testing docs for 1.8 unit testing labels Feb 15, 2024
@runleonarun
Copy link
Collaborator

@graciegoheen (sorry for repeating this question, just want to get a sense of completion times.) Do you need Docs support on this? I think we should aim to have all issues addressed by Friday 2/23 to give reviewers and authors enough time.

@graciegoheen
Copy link
Collaborator Author

@MichelleArk and I can pair on this and tag y'all for a review if that works?

graciegoheen added a commit that referenced this issue Feb 22, 2024
## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If related to an open 
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

Closes #4929

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/static/_redirects`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear unit testing docs for 1.8 unit testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants