Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique_key is not just for snapshots (also for incremental models) #4703

Closed
1 task done
graciegoheen opened this issue Jan 3, 2024 · 0 comments · Fixed by #6636
Closed
1 task done

unique_key is not just for snapshots (also for incremental models) #4703

graciegoheen opened this issue Jan 3, 2024 · 0 comments · Fixed by #6636
Assignees
@mirnawong1
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: medium Fix or enhancement to existing information that’s creating some requests from customers size: small This change will take 1 to 2 days to address

Comments

@graciegoheen
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

Currently, unique_key is nested in the snapshot configs.

Screenshot 2024-01-03 at 3 36 26 PM

https://docs.getdbt.com/reference/resource-configs/unique_key

However, this is also an important config for incremental models.

Screenshot 2024-01-03 at 3 37 20 PM

https://docs.getdbt.com/docs/build/incremental-models

What part(s) of the page would you like to see updated?

We should update the unique_key page (or make a second one under models), so it's clear this is a config for both snapshots and incremental models.

Additional information

No response
@graciegoheen graciegoheen added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: medium Fix or enhancement to existing information that’s creating some requests from customers size: small This change will take 1 to 2 days to address labels Jan 3, 2024
@mirnawong1 mirnawong1 self-assigned this Dec 5, 2024
@mirnawong1 mirnawong1 mentioned this issue Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear priority: medium Fix or enhancement to existing information that’s creating some requests from customers size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move unique_key page under general configs dbt-labs/docs.getdbt.com
2 participants
@graciegoheen @mirnawong1