Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback on CI jobs/ PR triggers #4344

Open
nghi-ly opened this issue Oct 26, 2023 · 0 comments
Open

Feedback on CI jobs/ PR triggers #4344

nghi-ly opened this issue Oct 26, 2023 · 0 comments
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@nghi-ly
Copy link
Contributor

nghi-ly commented Oct 26, 2023

Feedback from slack convo https://dbt-labs.slack.com/archives/C02NCQ9483C/p1698332049734869 on:
@nghi-ly nghi-ly added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Oct 26, 2023
@nghi-ly nghi-ly self-assigned this Nov 3, 2023
@nghi-ly nghi-ly mentioned this issue Jan 4, 2024
Merged
3 tasks
nghi-ly added a commit that referenced this issue Jan 22, 2024
@nghi-ly
Update to CI jobs page (#4706)
2efde10 
## What are you changing in this pull request and why?

Added content to the [CI jobs
page](https://docs.getdbt.com/docs/deploy/ci-jobs). This is related to
issue #4344 .

Updated sections:
- [Prerequisites for Set up CI
jobs](https://docs.getdbt.com/docs/deploy/ci-jobs#prerequisites) since
both native and non-native Git integrations are now supported in the UI
- [Trigger a CI job with the
API](https://docs.getdbt.com/docs/deploy/ci-jobs#trigger-a-ci-job-with-the-api)
to include the new `non_native_pull_request_id` field in step 2 of the
procedure

Extra credit work:
- Removed stale info that no longer applies with the support of
non-native Git integrations
- Added a removed section back in, per review discussion.  

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [x] Needs review from product team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nghi-ly