Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column quoting #4238

Closed
1 task done
alison985 opened this issue Oct 10, 2023 · 4 comments
Closed
1 task done

column quoting #4238

alison985 opened this issue Oct 10, 2023 · 4 comments
Labels
content Improvements or additions to content duplicate This issue or pull request already exists improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@alison985
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/reference/resource-configs/quote_columns
https://docs.getdbt.com/reference/project-configs/quoting

What part(s) of the page would you like to see updated?

These two pages need to be linked/reconciled/merged or something.

Additional information

No response

@alison985 alison985 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Oct 10, 2023
@alison985
Copy link
Contributor Author

Spoke too soon, there's also this: https://docs.getdbt.com/reference/resource-properties/tests#accepted_values

The problem that made me find all of these is trying to figure out why the dbt-core accepted_values: test fails because it's not quoting columns even though I have all the quote settings turned on. I have a hard time believing no one would have caught this before, so I'm trying to find something in the docs before filing a dbt-core bug report.

@alison985
Copy link
Contributor Author

@dbeatty10
Copy link
Contributor

See also: #3518

@dbeatty10
Copy link
Contributor

@alison985 Great point that we should link/reconcile/merge/something all these related pages 💡

I just added the key thing you pointed out about quote for accepted_values to #3518. If I missed anything, please comment within that issue 🙏

I think we have everything covered in #3518 now, so I'm going to close this one as a duplicate.

@dbeatty10 dbeatty10 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
@dbeatty10 dbeatty10 added the duplicate This issue or pull request already exists label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content duplicate This issue or pull request already exists improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

No branches or pull requests

2 participants